Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add H2 production technologies #1227

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

yerbol-akhmetov
Copy link
Collaborator

@yerbol-akhmetov yerbol-akhmetov commented Dec 6, 2024

Changes proposed in this Pull Request

Good day. This PR aims to integrate new H2 production technologies into the model. Technologies that are being add are: alkaline electrolyzer, PEM electrolyzer, SOEC electrolyzer, natural gas steam reforming (with/without CC), coal gasification (with/without CC), solid biomass steam reforming, solid biomass gasification (with/without CC), and heavy oil partial oxidation technologies.

In addition, currently existing H2 production technologies, such as H2 Electrolysis, SMR, and SMR CC, are re-organized and placed to add_hydrogen function of prepare_sector_network.py. Moreover, all H2 production technologies are grouped and listed in config file in a single place:

hydrogen:
    production:
        h2_electrolyzer: true
        SMR: true
        ....

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@davide-f
Copy link
Member

davide-f commented Dec 9, 2024

Great @yerbol-akhmetov :) please, when you wish a review, convert it into ready for review :D

@yerbol-akhmetov
Copy link
Collaborator Author

Great @yerbol-akhmetov :) please, when you wish a review, convert it into ready for review :D

Thanks, @davide-f. I have tested everything locally. To test you from your side and review, we think we need to wait for PR for cost assumption integration. However, I am open to discuss if you have some suggestions regarding readability of code.

@yerbol-akhmetov
Copy link
Collaborator Author

Hi, @davide-f, @hazemakhalek, @Eddy-JV. I would be glad if you could review the PR from general perspective. To full run, of course, US specific costs will be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants